search

bh / atom-python-isort

Atom.io plugin to sort Python imports
https://atom.io/packages/python-isort
MIT License
19 stars 10 forks source link

Support MagicPython grammar. #25

Closed lexicalunit closed 8 years ago

lexicalunit commented 8 years ago

Using .name when MagicPython is installed yields "MagicPython". This is different than what the default grammar language-python yields. This causes this package to fail to execute when using MagicPython. Prefer .scopeName which should always be "source.python" no matter what.

lexicalunit commented 8 years ago

I believe this is also a more robust solution than #21, but honestly how many Python grammars are there? I only know of MagicPython and the default language-python.

hvdklauw commented 8 years ago

There is also "Django Python"

Please merge this and release an update :)

lexicalunit commented 8 years ago

I think I'm gonna fork this repo later today and make some additional changes like those I recently submitted to atom-python-yapf which operates very very similarly to this package. It's been a year since this package was last updated. I think it might be abondoned at this point :(

lexicalunit commented 8 years ago

@hvdklauw https://atom.io/packages/atom-isort is a fork of this package that resolves: #25, #28, #27, #21 and probably a whole lot of the issues opened against this repo.

hvdklauw commented 8 years ago

Awesome, I'll have a look!

On Tue, 14 Jun 2016, 23:24 Amy Troschinetz, notifications@github.com wrote:

@hvdklauw https://github.com/hvdklauw https://atom.io/packages/atom-isort is a fork of this package that resolves: #25 https://github.com/bh/atom-python-isort/pull/25, #28 https://github.com/bh/atom-python-isort/pull/28, #27 https://github.com/bh/atom-python-isort/pull/27, #21 https://github.com/bh/atom-python-isort/pull/21 and probably a whole lot of the issues opened against this repo.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/bh/atom-python-isort/pull/25#issuecomment-226020794, or mute the thread https://github.com/notifications/unsubscribe/AAA2M3Qu63hablWR5WOT4mf2dmXpg1hCks5qLxv-gaJpZM4HbQwT .