search

bh / atom-python-isort

Atom.io plugin to sort Python imports
https://atom.io/packages/python-isort
MIT License
19 stars 10 forks source link

currently doesn't work #26

Open michaelaye opened 8 years ago

michaelaye commented 8 years ago

I don't know what changed, but currently isort does not work for me. I have the explicit path set in the settings to

/Users/klay6683/miniconda3/envs/py35/bin/isort

and confirmed that isort works on the command line with this path. I have activated check on save and sort on save for trying it out, usually I only sort via command-palette. But neither of these approaches work.

My versions: atom: 1.5.3 python-isort: 0.0.7

Is there any thing I can debug on my end?

monkpit commented 8 years ago

This package didn't work for me either, and then I figured out my problem was caused by this package not supporting MagicPython syntax. #23

hvdklauw commented 8 years ago

I'll chip in, it does not work with any other python syntax except "Python"

michaelaye commented 8 years ago

I remember darkly that one has to put the name of the Python package in some config file somewhere to make this work for other atom packages that were not aware of MagicPython. Somebody remembers that solution and tried it?

hvdklauw commented 8 years ago

It should work now, this was fixed in 5e713c8fa7f8f3dff04c5cd7db8d2fe85e3a9e76

michaelaye commented 8 years ago

Pity you didn't release the fix, considering you had it in Feb. :( But thanks for your package anyway!

michaelaye commented 8 years ago

I put this fix in manually, but that doesn't solve it.