bh2smith / dune-sync

GNU General Public License v3.0
2 stars 2 forks source link

Unnecessarily strict env var check #77

Closed fleupold closed 4 days ago

fleupold commented 4 days ago

It's in theory possible to use different env vars in the sources or not have e.g. a postgres db at all (ie to mirror between dune accounts).

https://github.com/bh2smith/dune-sync/blob/aac96341fc84850491d518427115fa86f5a32198/src/config.py#L108-L111

I don't think we should be enforcing the existence of certain env variables as this would be a perfectly valid config:

sources:
  - name: Dune
    type: dune
    key: ${DUNE_API_KEY}
  - name: PG
    type: postgres
    key: ${READONLY_DB}

destinations:
  - name: Dune
    type: dune
    key: ${DUNE_API_KEY}
bh2smith commented 4 days ago

Right, ya this is old code from before we had the config template. Never noticed because these are common env vars... Will fix.