bhanderson / pbnh

mix between pb and haste
MIT License
12 stars 8 forks source link

Dockercompose #33

Closed jetpacktuxedo closed 6 years ago

jetpacktuxedo commented 6 years ago

Probably should have some tests associated with this but #yolo or something

jetpacktuxedo commented 6 years ago

Tests fail because you got rid of the requirements file and I pulled that in from your other branch :P

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 87.774% when pulling 926bcda1cd522e43ac76345a94f55c6ecdaa42c9 on dockercompose into 7ffee5c87df965a6b839509197a6c5110f1e7de0 on master.

jetpacktuxedo commented 6 years ago

Fixed that, now it is failing because I changed how we handle secrets.yml in order to make it more docker-friendly. I'm not really sure where travis is pulling that stuff from though.

Edit: that is why coveralls tanked as well I think.

bhanderson commented 6 years ago

Is there docs how to run it?

jetpacktuxedo commented 6 years ago

docker-compose build will build it, docker-compose up will bring it online

docker compose up --build should do both at once iirc.

Container should grab :5000 when it comes up.

That should probably be in the readme or something though.

You'll also need to take your secrets.yml and put it in ~/.config/.pbnh.yml. docker-compose uses that file to populate the "secrets" for the container.

bhanderson commented 6 years ago

There isn't a docker compose file to build?

jetpacktuxedo commented 6 years ago

... did I not git add that?

😂🔫👌

jetpacktuxedo commented 6 years ago

All my tests pass locally so I am pretty sure the secrets.yml is the only reason this is still failing... lemme try something else

jetpacktuxedo commented 6 years ago

Yeah, that didn't help... I have no idea how you are setting up secrets stuff for travis

jetpacktuxedo commented 6 years ago

ayyyyyy :point_right: :sunglasses: :point_right:

I figured it out

jetpacktuxedo commented 6 years ago

Just found another bug with this... for some reason about.md never gets rendered.

Tracking it down now.

bhanderson commented 6 years ago

Cool

jetpacktuxedo commented 6 years ago

fixed