search

bharadwaj-raju / WeatherDesk

MOVED: https://gitlab.com/bharadwaj-raju/WeatherDesk
https://gitlab.com/bharadwaj-raju/WeatherDesk
GNU General Public License v3.0
217 stars 31 forks source link

Time only flag #41

Closed AKuederle closed 6 years ago

AKuederle commented 6 years ago

Added an option to disable the weather functionality. With the --no-weather flag WeatherDesk will need no internet functionality and will only use the time of the day to change the wallpaper.

Would be cool if someone second could verify, that this works correctly.

bharadwaj-raju commented 6 years ago

Another good pull request!

Minor error: in the README, in the naming of files section, there is this:

If you use --no-weather, the files have to be named simply after the time of day depending of your 
time schema.
E.g.: "day.{0}", "night.{0}"

I think you meant to use Python's str.format() to do something with those {0}s?

Fix that and this is ready to pull!

AKuederle commented 6 years ago

Oh you are right. I will check whats going on there.

AKuederle commented 6 years ago

Ok it was just copy-and-paste blindness I guess.

bharadwaj-raju commented 6 years ago

I also fixed it in the output of --naming in WeatherDesk.py just now.

Thanks a lot for taking the time out to help!

AKuederle commented 6 years ago

Sure thing!