bharat-1809 / glass_kit

💎 A package containing widgets to implement glass morphism in flutter apps
https://pub.dev/packages/glass_kit
MIT License
80 stars 15 forks source link

Removed Unwanted Center Widget #5

Closed KABILAN235 closed 3 years ago

KABILAN235 commented 3 years ago

Removed Unwanted Center Widget, which was responsible for Unwanted Behaviour of the GlassContainer Widget in Some Layouts like GridView, Wrap,etc

bharat-1809 commented 3 years ago

Hi @KABILAN235 👋🏻 Thanks for opening a pull request!
Can you share a screenshot of the problem for a better understanding?

KABILAN235 commented 3 years ago

Hi!

So before the Edit, The App Looks Like This

Screenshot 2021-06-15 at 5 42 11 PM

As You Can See Some Glass Widgets are Centred. The "Add" Button Was Actually A Floating Action Button, Location Set to Bottom, But It Appears at the Middle.

Behind The Add Button, There are Some Elements to Represent Chips, To Be Arranged in a Row, using the Wrap Layout, But It Was Aligned Vertically, As Seen.

Code for widgets

Floating Action Button

Screenshot 2021-06-15 at 5 49 09 PM

Applying the Fix, The App Looks Much Better

Screenshot 2021-06-15 at 6 48 56 PM

Everything Works Fine.

I Just Modified the Pub Cache to fix this Issue, Just Had an Idea to Update The Main Package, I am New To This Github Stuff, Just Looked up YouTube on How to Suggest Changes. Sorry if Something Went Wrong.

Kabilan

bharat-1809 commented 3 years ago

Hi @KABILAN235 It was a pretty notorious bug, thanks for the pull request 👍🏻 . I am glad that you are starting your open source journey by contributing to our package.

Just some things to do before the PR can be merged:

The above points are necessary for the tests to pass. Ping me if you need any help.

Thanks :)

bharat-1809 commented 3 years ago

@all-contributors please add @KABILAN235 for bug and code

allcontributors[bot] commented 3 years ago

@bharat-1809

I've put up a pull request to add @KABILAN235! :tada: