Closed KABILAN235 closed 3 years ago
Hi @KABILAN235 👋🏻
Thanks for opening a pull request!
Can you share a screenshot of the problem for a better understanding?
Hi!
So before the Edit, The App Looks Like This
As You Can See Some Glass Widgets are Centred. The "Add" Button Was Actually A Floating Action Button, Location Set to Bottom, But It Appears at the Middle.
Behind The Add Button, There are Some Elements to Represent Chips, To Be Arranged in a Row, using the Wrap Layout, But It Was Aligned Vertically, As Seen.
Code for widgets
Floating Action Button
Applying the Fix, The App Looks Much Better
Everything Works Fine.
I Just Modified the Pub Cache to fix this Issue, Just Had an Idea to Update The Main Package, I am New To This Github Stuff, Just Looked up YouTube on How to Suggest Changes. Sorry if Something Went Wrong.
Kabilan
Hi @KABILAN235 It was a pretty notorious bug, thanks for the pull request 👍🏻 . I am glad that you are starting your open source journey by contributing to our package.
Just some things to do before the PR can be merged:
flutter test --update-goldens
this is necessary as the change affects the appearance and the tests may fail.flutter analyze .
flutter format .
The above points are necessary for the tests to pass. Ping me if you need any help.
Thanks :)
@all-contributors please add @KABILAN235 for bug and code
@bharat-1809
I've put up a pull request to add @KABILAN235! :tada:
Removed Unwanted Center Widget, which was responsible for Unwanted Behaviour of the GlassContainer Widget in Some Layouts like GridView, Wrap,etc