search

bharbron / hexbook-semantic

An Electron-React-Redux-Semantic-UI application for automatically generating a hexcrawl campaign notebook from random tables.
5 stars 3 forks source link

SingleLineAdderV2 is now SingleLineAdder #25

Closed jvdoorn closed 6 years ago

jvdoorn commented 6 years ago

As mentioned in #24 I first renamed all uses of SingleLineAdder to SingleLineAdderV2, and then removed the SingleLineAdder class. Finally, I renamed all uses of SingleLineAdderV2 back to SingleLineAdder including the class defenition.

bharbron commented 6 years ago

Thanks for the submission. This will unfortunately break submission of the value from the SingleLineAdder being used in src/components/tableentries.js. There are subtle differences between SingleLineAdder and SingleLineAdderV2 that must be accounted for, primary that SingleLineAdder tracks value in its own internal state, pushing it up to its parent on submission, while SingleLineAdderV2 is "controlled" component, with the expectation that value is being tracked in its parent's state.

(Overall, this project could benefit from any kind of automated test coverage to catch these kind of things. Probably not in a great state for public submissions at the moment, but thank you.)