search

bharbron / hexbook-semantic

An Electron-React-Redux-Semantic-UI application for automatically generating a hexcrawl campaign notebook from random tables.
5 stars 3 forks source link

Change widgets for BookContentSettings #61

Open bharbron opened 5 years ago

bharbron commented 5 years ago

In the BookContentSettings component, we are currently using a custom component where you click a pencil icon, it turns the current setting value into a dropdown, you select the value, it update the state, and the dropdown turns back into text of the new setting value.

It's nifty, but it doesn't work too well. Some weird bugs with it (mostly related to onBlur() not working as expected). We could try to fix those bugs, but instead, let's just use a straightforward Semantic <Form><Form.Group><Form.Select /></Form.Group></Form> for this. It will look good, be easy to understand, and functional.

bharbron commented 5 years ago

This may be an even better option. Clean looking, easy code:

https://react.semantic-ui.com/modules/dropdown/#usage-upward-inline

May be worth going back and using this on the TemplateEditModal as well.