Closed michcio1234 closed 1 year ago
@bharel updated. 👍🏻 I definitely agree with your comments. I believe this simpler version is better. Initially I just wanted to stay consistent with existing code. :)
Awesome!
The code is already consistent with past versions of course and with the other classes, as it's a public attribute :-)
If you're referring to rate being a property then you'll see it has a tiny bit of logic for runtime optimization.
Last but not least, we need to update the documentation to account for the new __init__
. See how LeakyBucket
looks like in index.rst
.
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
27a26af
) compared to base (bff0e4c
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Nice, thank you! :)
max_burst
is now an argument toLimiter.__init__
.Tests and docs were adjusted accordingly.
By the way, thanks for the great package. :)