search

bharel / asynciolimiter

A simple yet efficient Python AsyncIO rate limiter.
MIT License
13 stars 2 forks source link

Add type hints #8

Open vectro opened 2 weeks ago

vectro commented 2 weeks ago

It would be great if this module had type hints, so that it could be used in type-checked projects.

bharel commented 2 weeks ago

Sounds like a great idea. It's not too hard. Do you want to open a PR or shall I make one?

vectro commented 2 weeks ago

I do not have the bandwidth to take this on right now, if you are able to do it, go for it!

bharel commented 2 weeks ago

It's actually almost fully type hinted. Do you have an issue during usage?

bharel commented 2 weeks ago

Oh I think py.typed is missing because it's a single module package

vectro commented 2 weeks ago

That sounds right, mypy is giving me this error:

error: Skipping analyzing "asynciolimiter": module is installed, but missing library stubs or py.typed marker  [import]
bharel commented 2 weeks ago

Please check now. 1.1.0 released