Display colored favicon to indicate current test results

[cjohansen]

I recently saw your first talk showcasing figwheel, and I really liked the favicon trick you employed on running tests with it. So I found a gist of yours and added the feature to devcards when running tests.

When devcards is running tests, it will keep tabs on all tests currently rendered on the page. If there are any failures, it adds a red favicon, otherwise it adds a green favicon.

[bhauman]

this is pretty rad, have you tried it in different browsers?

[cjohansen]

Since you ask, I tried a few more 😁 Seems it doesn't sit well with Safari. I can look into that tomorrow (it's bedtime over here in Norway) and see if I can fix it. Works in Chrome and Firefox on OSX.

[bhauman]

thanks for checking into it, working on chrome and firefox is probably good enough

On Wed, Jun 6, 2018 at 1:49 PM, Christian Johansen <notifications@github.com

wrote:

Since you ask, I tried a few more 😁 Seems it doesn't sit well with Safari. I can look into that tomorrow (it's bedtime over here in Norway) and see if I can fix it. Works in Chrome and Firefox on OSX.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bhauman/devcards/pull/139#issuecomment-395208908, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAKQOUqolulq9hoiUR6Tv72UvD-CGN6ks5t6EBSgaJpZM4UdSZJ .

[cjohansen]

I looked into it some more. It appears Safari doesn't do favicons on tabs at all, only for pinned tabs. For some reason, these favicons don't display even on pinned tabs in Safari. Honestly, I don't use Safari that actively for development, and thus am not super motivated to figure it out. Maybe Firefox and Chrome (and Brave, btw) can be a good start, and then Safari favicons can be an improvement up for grabs? :)

[bhauman]

I'm still planning on merging this, I just need to kick the tires a bit.