Improve Om Next cards story

[anmonteiro]

this patch improves the recently added support for mounting Om Next components into devcards by adding:

• a defrecord implementation of IDevcard specifically for Om Next components
• an OmNextNode that knows how to mount and reload Om Next components
  • this component builds on some of the logic that was in place, so a little code refactor was done in order to take advantage of some of that logic
  • with this is place, it is now possible to use Devcards options such as :inspect-data, :history and watch-atom(!)
• more examples to the devdemos pages which include a version of the BMI component (with :inpect-data and :history set to true) and a short note on how to write reloadable Om Next code

[anmonteiro]

Added comments regarding the needed changes and additions :)

[bhauman]

Thanks man!

[bhauman]

I'm hoping to see how the current methods of extension are failing you or if we can actually use them.

[anmonteiro]

Sorry, I don't understand your last comment; what do you mean?

[bhauman]

OK it was hard to see what you added because of the single commit.
But basically you added an alternate main option and a react-key.

Here is what I'm thinking so far. I will definitely pull in render-base with the alternate main and that react-key parameter. But you might want to keep the Om Next specific stuff in Om Next or a micro library for a little bit.

The reason is that getting the reload behavior you want during development is going to probably take some tweaking. If you keep the Om Next helpers in a separate lib then you can tweak the heck out of them until you get the behavior you want. Then once it's solid then we should consider putting it into Devcards. But its highly likely that there will be some high churn in the near future.

[anmonteiro]

@bhauman OK, just removed the Om Next specific parts and I'll work on pushing an Om Next specific micro-repository

[anmonteiro]

However, will need a release whenever this gets merged, if possible, so that I can take advantage of e.g. render-base

[bhauman]

Alrighty, trying to get to it today. Looks good though.

On Sat, Jan 23, 2016 at 11:25 AM, António Nuno Monteiro < notifications@github.com> wrote:

However, will need a release whenever this gets merged, if possible, so that I can take advantage of e.g. `render-base´

— Reply to this email directly or view it on GitHub https://github.com/bhauman/devcards/pull/91#issuecomment-174197874.

[bhauman]

Been working on this this evening. Found a regression where components that with local state are getting blown away. Trying to track that down first.

[bhauman]

This wasn't introduced by your patch. It happened a few versions back.

[anmonteiro]

no rush :)

[bhauman]

I think I obviated the need for the react-key parameter.

See this commit: 7778d1622aa245e8e141e7b6c6095e4f1c94bc13

I think you were having to do that to get around a bug. Do you want to try against master and see if things work without the react-key parameter?

[anmonteiro]

Will do and let you know.

However, I'd still need render-base to be its own, public thing in order to make an Om Next specific card (because they mount in a different way, so the main override would still be a thing). I'll update the patch accordingly

[anmonteiro]

@bhauman alright, your changes in 7778d1622aa245e8e141e7b6c6095e4f1c94bc13 are indeed working for me without the react-key parameter. I've rebased my branch on the current master and kept the changes regarding render-base.

[bhauman]

@anmonteiro this is the next thing on my priority list. Sorry for all the back and forth. But I really want to get extension right. Can you send me a link to a repo or a gist that has your current card implementations? I suspect that you should/could be using iDevcard and I'm curious about a couple of other things. I may refactor render-base a bit ...

[anmonteiro]

@bhauman I am using IDevcard but I don't want to render using DevcardBase. I want to have my own component (that knows how to mount an Om Next component) but still keep the same rendering behavior as in my render-base. Here's what I'm currently doing (using the devcards branch I've submitted in this PR).

[bhauman]

Thanks. Ok I see a good way forward.

[bhauman]

I'm going to make a couple of changes.