search

bhauman / figwheel-main

Figwheel Main provides tooling for developing ClojureScript applications
https://figwheel.org
Eclipse Public License 1.0
640 stars 93 forks source link

clojure.data.json dep missing #329

Open lgrapenthin opened 2 years ago

lgrapenthin commented 2 years ago

ClojureScript 1.11.51 doesn't pull that one in anymore...

bhauman commented 2 years ago

Good one! I'll fix that.

bhauman commented 2 years ago

Hmmm did you add the dep in your local project, and did everything work. Because I'm now getting a missing cljs/vendor/bridge.clj file now. Are you getting that?

lgrapenthin commented 2 years ago

Yes

On Monday, May 16, 2022, Bruce Hauman @.***> wrote:

Hmmm did you add the dep in your local project, and did everything work. Because I'm now getting a missing cljs/vendor/bridge.clj file now. Are you getting that?

— Reply to this email directly, view it on GitHub https://github.com/bhauman/figwheel-main/issues/329#issuecomment-1127096145, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHNB7AOCYLLLVN6PRD2EETVKGH4DANCNFSM5V63MK2Q . You are receiving this because you authored the thread.Message ID: @.***>

bhauman commented 2 years ago

Wait, my question was sprawling, so you are missing the cljs/vendor/bridge.clj file now?

svenlaater commented 2 years ago

Wait, my question was sprawling, so you are missing the cljs/vendor/bridge.clj file now?

yes

Maybe related to this https://github.com/clojure/clojurescript/compare/cljs-3375?

Also, production builds pass when org.clojure/data.json is added to deps but starting REPL does not.

Results: Stored in vars *1, *2, *3, *e holds last exception object
[Rebel readline] Type :repl/help for online help info
Execution error (FileNotFoundException) at cljs.repl/repl* (repl.cljc:1060).
Could not locate vendor/bridge__init.class, vendor/bridge.clj or vendor/bridge.cljc on classpath.

com.bhauman/figwheel-main {:mvn/version "0.2.17"}

bhauman commented 2 years ago

cool thanks!

bhauman commented 2 years ago

So for now the simple solution right now is to add clojure.data.json, as a dependency and use a ClojureScript 1.11.54 when it is released momentarily.

I will also release figwheel-main 0.2.18 which will include the clojure.data.json dep in it.

johanatan commented 1 year ago

Is this going to be fixed anytime soon? Pretty bad look for a project to require users to just randomly add dependencies its upstream dependencies require.