search

bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 209 forks source link

emoticon prevents paredit mode #568

Closed dpsutton closed 7 years ago

dpsutton commented 7 years ago

This is a rather silly issue, but when i try to turn on paredit-mode in an inf-clojure figwheel repl I am prevented by the following otherwise charming output:

Figwheel: Configuration Valid :)

I think fundamental to paredit is that it can only work if delimiters are balanced and this happy face really makes it sad. Is this properly a paredit mode issue or is this something that could be addressed here?

bhauman commented 7 years ago

Well to me its "critical" to fix this while maintaining its charming nature. ;)

Can we think of more balanced ways of expressing this perhaps :smiley-face:?

glenjamin commented 7 years ago

😀

danielcompton commented 7 years ago

Not sure whether paredit mode detects comments, but adding a ; could work. Alternatively a real smile emoji would be cool.

dpsutton commented 7 years ago

it seems to handle the emoticon in a comment just fine. I was thinking a smile emoji but i'm not sure of the terminals and other locations people use this and if that might break them more than a simple unbalanced ).

bhauman commented 7 years ago

The simplest solution is ;) An emoji is an interesting solution but having garbage output after a "Configuration valid" message could be confusing, even if part of me enjoys the irony.