search

bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 209 forks source link

Error accessing localStorage when checking autoload? #581

Closed jeaye closed 7 years ago

jeaye commented 7 years ago

I'm currently getting this sporadically:

figwheel-error

It happens typically in one of two cases:

  1. Startup
  2. Reloading after files changed

When inspecting it, in the debugger, I can see that localStorage is non-nil, but it doesn't have a getItem function on it. I'm not sure why this happens, and what it just started happening, but it's a blocker.

The relevant CLJS, as shown in the image is here: https://github.com/bhauman/lein-figwheel/blob/48eba2f7e481be4079fdfc4b606d3eb52217a891/support/src/figwheel/client/utils.cljs#L132

Looks like this issue might be related to: https://github.com/bhauman/lein-figwheel/issues/313 and perhaps the fix for #313 was incomplete.

jeaye commented 7 years ago

What's your release schedule for clojars? I'm currently running on a modified local install of this, with the fix, but would like to get it to my other teammates.

bhauman commented 7 years ago

I can push a snapshot out until the next release

jeaye commented 7 years ago

Sounds good to me, thank you!

bhauman commented 7 years ago

I just deployed it a bit ago 0.5.12-SNAPSHOT

On Jul 25, 2017, at 12:48 PM, Jeaye Wilkerson notifications@github.com wrote:

Sounds good to me, thank you! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/bhauman/lein-figwheel/issues/581#issuecomment-317797791, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAKQPcOa51YpidPLQ_44X2h0I4cVpNJks5sRhx3gaJpZM4Of-9P.

jeaye commented 7 years ago

Cheers!