search

bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 209 forks source link

Add install-deps key to cljs_options #588

Closed ajpierce closed 7 years ago

ajpierce commented 7 years ago

As of Clojurescript 1.9.854, the compiler no longer automatically downloads javascript dependencies defined in :npm-deps. However, the Clojurescript team added a new flag to the compiler, :install-deps, that, when set to true, will download the JS dependencies for you.

This PR adds the :install-deps key to cljs_options to allow users to pass this flag through to the compiler for automatic JS dependency downloading.

Thanks for all your hard work, Bruce! Let me know if there's anything you'd like me to change or add to this PR :)

bhauman commented 7 years ago

This is a good start. Do a search for ::npm-deps in the file to find the other reference as an example of what else is needed here.

ajpierce commented 7 years ago

Ok, I've added the missing key to the compiler options, sorry about that! I went ahead and rebased the commits so as not to clutter up the commit history.

Let me know if there's anything else I'm missing, and thanks for the help!

bhauman commented 7 years ago

Thanks!!