search

bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 209 forks source link

Broken with new Closure library #594

Closed Deraen closed 7 years ago

Deraen commented 7 years ago

Next ClojureScript updates Closure-library version

New version removed deprecated jsloader load function: https://github.com/google/closure-library/commit/988ff900886e959a888485ee56d1540d1bf2f29d

https://github.com/bhauman/lein-figwheel/blob/48eba2f7e481be4079fdfc4b606d3eb52217a891/support/src/figwheel/client/file_reloading.cljs#L208

Instead, one needs to use goog.html.legacyconversions to create safeUrl and use safeLoad function instead.

Same fix at Boot-reload: https://github.com/adzerk-oss/boot-reload/commit/025dfbc1ecb772d0193060430a5ea45c6563ba84

bhauman commented 7 years ago

Updated fix here https://github.com/bhauman/lein-figwheel/commit/9e8e6d4504c807f8a41767075bf86cbab67df6d1

njordhov commented 6 years ago

Work-around until the next release restores figwheel's ability to reload compiled files:

(set! js/goog.net.jsloader.load
    #(goog.net.jsloader.safeLoad
        (goog.html.legacyconversions/trustedResourceUrlFromString %1)
        %2))
bhauman commented 6 years ago

This has been released already.

On Oct 2, 2017, at 10:11 PM, Terje Norderhaug notifications@github.com wrote:

Work-around until the next release restores figwheel's ability to reload compiled files:

(set! js/goog.net.jsloader.load

(goog.net.jsloader.safeLoad

    (goog.html.legacyconversions/trustedResourceUrlFromString %1)
    %2))

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.