search

bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 208 forks source link

React Native reloading broke #616

Closed jeaye closed 7 years ago

jeaye commented 7 years ago

I'm using 0.5.14, but I'm seeing this: https://github.com/drapanjanas/re-natal/issues/99

Based on my research, this commit broke reloading in ReactNative: https://github.com/bhauman/lein-figwheel/commit/a3938056c7aad62b588b4b0826c6b20746b6f71a

React Native is no longer supported in reload-file*: https://github.com/bhauman/lein-figwheel/blob/381ed0ccb3de66c6f4cbf8bb9ccc48c093694baa/support/src/figwheel/client/file_reloading.cljs#L264-L274

Is this intentional, or am I missing something? I'm, unfortunately, unable to do any live reloading now.

bhauman commented 7 years ago

You need to use the latest version of re-natal with figwheel 0.5.14

On Oct 10, 2017, at 1:22 AM, Jeaye Wilkerson notifications@github.com wrote:

I'm using 0.5.14, but I'm seeing this: drapanjanas/re-natal#99

Based on my research, this commit broke reloading in ReactNative: a393805

React Native is no longer supported in reload-file*: https://github.com/bhauman/lein-figwheel/blob/381ed0ccb3de66c6f4cbf8bb9ccc48c093694baa/support/src/figwheel/client/file_reloading.cljs#L264-L274

Is this intentional, or am I missing something? I'm, unfortunately, unable to do any live reloading now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

bhauman commented 7 years ago

Specifically the changes that are in figwheel bridge.

On Oct 10, 2017, at 1:22 AM, Jeaye Wilkerson notifications@github.com wrote:

I'm using 0.5.14, but I'm seeing this: drapanjanas/re-natal#99

Based on my research, this commit broke reloading in ReactNative: a393805

React Native is no longer supported in reload-file*: https://github.com/bhauman/lein-figwheel/blob/381ed0ccb3de66c6f4cbf8bb9ccc48c093694baa/support/src/figwheel/client/file_reloading.cljs#L264-L274

Is this intentional, or am I missing something? I'm, unfortunately, unable to do any live reloading now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jeaye commented 7 years ago

Thanks for the quick reply. I'm on 0.7.0, as per:

$ re-natal --version
0.7.0

Looks like there's a 0.7.1 though, so I'll upgrade to that and report back.

jeaye commented 7 years ago

Updating to 0.7.1. didn't change the error I'm seeing. That is, "Reload not defined for this platform" being thrown when a file changes.

My suspicion, since re-natal changes were required for this fix, is that the re-natal config layout changed in a way which doesn't progress old users forward. So I may be stuck with some baggage from the time before this fix. Just a guess, right now.

jeaye commented 7 years ago

Matching my suspicion, it looks like I didn't run the upgrade procedure documented here: https://github.com/drapanjanas/re-natal/blob/ac78028655a55c98c6f8b6f381450929995fcfef/README.md#upgrading-re-natal-cli-version

After upgrading, I'm still seeing this issue.

$ re-natal --version
0.7.1
$ re-natal use-android-device "192.168.0.12"
Using development host IP: '192.168.0.12'
Please run: re-natal use-figwheel to take effect.
$ re-natal upgrade
upgraded .re-natal
upgraded files in env/dev and env/prod 
upgraded figwheel-bridge.js
To upgrade React Native version please follow the official guide in https://facebook.github.io/react-native/docs/upgrading.html
$ re-natal use-figwheel
Cleaning...
index.ios.js was regenerated
index.android.js was regenerated
Host in RCTWebSocketExecutor.m was updated
Dev server host for iOS: localhost
Dev server host for Android: 192.168.0.12

The figwheel-bridge.js diff appears now: https://gist.github.com/jeaye/ba9513abcbe1d0ca0014af8e2a878fb4

I still can't reload though.

jeaye commented 7 years ago

Gah, found it. After the upgrade, I also needed to run react-native run-android to install a new version on there. I'll mention this in the re-natal ticket, so the docs can be updated. Apologies for the noise; hopefully this serves as documentation for anyone else in this pickle.

Thanks for the help.