search

bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 210 forks source link

Add :cljs-build-fn to the lein-project schema #619

Closed plexus closed 6 years ago

plexus commented 6 years ago

According to the CHANGELOG since 0.5.0 the build-fn can be specified from the config, but the schema validation wasn't aware of it, so actually doing so would result in an error. This adds it to the schema so the option is recognized.

If this is good to go maybe we can also document it on https://github.com/bhauman/lein-figwheel/wiki/Configuration-Options?

Thanks!

bhauman commented 6 years ago

Hey looks good. It doesn't validate the type of the arg, but in this case I think we are better off.

I didn't include this in the validation bc, quite frankly, I didn't see it being used from leiningen at all.

plexus commented 6 years ago

We're using this from sidecar. Our use case is we want to detect that the initial build has finished to kick off a node process.

We're making due to with :validate-config false.

Does this need any more work from my part?

bhauman commented 6 years ago

Ahh that makes sense. This is good to go!

plexus commented 6 years ago

Thanks! I tried to document it here https://github.com/bhauman/lein-figwheel/wiki/Configuration-Options

see if that phrasing makes sense.