bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 210 forks source link

Update for :npm-deps false and latest :npm-deps docs #678

Closed mfikes closed 6 years ago

mfikes commented 6 years ago

Allow :npm-deps to additionally take on the value of false. This is allowed with ClojureScipt 1.10.238 (see https://github.com/clojure/clojurescript/commit/486de1a8b0836dbe3a622662a69f57aa92d232de)

Also update the doc string to match the :npm-deps site documentation (https://clojurescript.org/reference/compiler-options#npm-deps)

mfikes commented 6 years ago

By the way, this will be really nice for React Native Figwheel users: A gigantic node_modules tree gets created for use by the React Native packager, and ClojureScript doesn't need to process that tree. By being able to set this to false users will have Figwheel start up instantly (for me, without this, approximately 45 seconds are taken while the compiler needlessly indexes node_modules).

bhauman commented 6 years ago

Thanks Mike!

vkramskikh commented 6 years ago

Thanks! Must have for reagent-0.8-based projects. Any plans to release this?