search

bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 210 forks source link

[fw-main] :ua-product is chrome in node target #700

Open arichiardi opened 6 years ago

arichiardi commented 6 years ago

Probably minor, but it seems that :ua-product is wrong in exception with :target :node.

I noticed this today:

 1. Unhandled clojure.lang.ExceptionInfo
   #object[ReferenceError ReferenceError: config is not defined]
   {:type :js-eval-exception,
    :error
    {:status :exception,
     :value
     "#object[ReferenceError ReferenceError: config is not defined]",
     :ua-product :chrome,
     :stacktrace
...

And figured I should report it :wink:

bhauman commented 6 years ago

I think this is expected. This is used to tell the cljs.repl how to interpret a stacktrace and Node produces a Chrome-like stacktrace.

arichiardi commented 6 years ago

Oh ok I think I was using :ua-product :node in lumo. Pretty sure the cljs compiler handles that but would not know what the difference is.