search

bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 210 forks source link

error trying to require a Javascript module with an @ character #717

Closed carocad closed 5 years ago

carocad commented 5 years ago

I am using the figwheel bridge together with the Expo template for a react native app.

I just migrated to node.js compilation target and started using js interop for requiring modules through the namespace form.

Everything seems to work fine for "standard" requires (those with simple names like react, react-native, expo) but if I try something like below then figwheel complains it cannot read it.

screen shot 2018-11-05 at 14 00 34
bhauman commented 5 years ago

This is ClojureScript issue

carocad commented 5 years ago

@bhauman sorry for the poorly explained issue. You are right that the issue is from Clojurescript, however, the issue that I wanted to point out is that it is not possible to know what went wrong on the repl since figwheel doesnt show it.

The feedback simply says message from client couldnt be read, which of course could mean a lot of things.

Would it be possible to improve that? I would be willing to help if possible :)

bhauman commented 5 years ago

I think this is fixed in figwheel-main. I'm suggesting that folks move over as the improvements are many.

bhauman commented 5 years ago

When I say fixed I mean that the message is a tad clearer.