search

bhauman / lein-figwheel

Figwheel builds your ClojureScript code and hot loads it into the browser as you are coding!
Eclipse Public License 1.0
2.88k stars 210 forks source link

Remove `tools.nrepl` dependency #718

Closed PEZ closed 5 years ago

PEZ commented 5 years ago

To make things work with lein master. Seems like the precense of tools.nrepl in the deps make the dynamic selection of which nrepl middleware to use fail.

The reformatting was done by cljfmt in my editor. I left them, since they make sense. Let me know if they shouldn't be part of the PR.

PEZ commented 5 years ago

If there is there something missing in this PR, please let me know.

bhauman commented 5 years ago

What is lein-master? Nrepl is a requirement for figwheel but perhaps lein-figwheel should depend on the new nrepl/nrepl at this point.

bhauman commented 5 years ago

sorry for the delay I'm not getting any notifications from gitihub on many of my projects.

bhauman commented 5 years ago

This current patch breaks using figwheel-sidecar as a standalone library, which makes this a bigger issue.

bbatsov commented 5 years ago

@bhauman The current Lein release ships with nREPL 0.5.3, so probably it makes sense to update this dependency indeed. I think it's safer for projects to depend on the new nREPL and fallback to the old one if someone's running on a older leiningen.

bhauman commented 5 years ago

I'm changing the nrepl dep to nrepl/nrepl 0.5.3