fix #139: swap not returning true on key-map change

bhauman / rebel-readline

Terminal readline library for Clojure dialects

Eclipse Public License 1.0

680 stars 37 forks source link

fix #139: swap not returning true on key-map change #144

Closed i-blis closed 6 years ago

i-blis commented 6 years ago

I've been looking into the issue #139 and it happened that the problem comes ultimately from your implementation of swap which failed to return true on successful change. Once spotted, the fix is a tiny one.

I tested but manually... :

rebel-dev.main=> (:key-map @api/*line-reader*)   
:emacs  
rebel-dev.main=> :repl/set-key-map :viins  
Changed key map to :viins  
rebel-dev.main=> (:key-map @api/*line-reader*)  
:viins

bhauman commented 6 years ago

And thanks for working on this!