Add deps.edn to allow use of master with clojure

[seancorfield]

Currently, clojure has to specify rebel-readline as a :mvn/version dependency and can only pull in released versions. It would be great if you provided deps.edn so clojure users could specify the dependency as a :git/url and :sha to pull down and test unreleased versions.

[bhauman]

Added a deps.edn file, it works locally just fine. Please give it a try and see if it's working correctly for you.

[seancorfield]

This doesn't work because the deps.edn file is not at the top of the GitHub repo.

  :rebel {:extra-deps {com.bhauman/rebel-readline
                       {:git/url "https://github.com/bhauman/rebel-readline"
                        :sha "c943ebe6d8ebc577414927c5df86f523f4c1c6c8"}}
          :main-opts ["-m" "rebel-readline.main"]}

(because the project folks need to run is not at the root of the repo)

I wonder if there's a way to make this work -- @puredanger is this setup possible with deps.edn at the moment or would it need an enhancement?

[bhauman]

This I could put one at the top that had the right source-paths and included both readline and cljs libraries in the short term

On Sep 16, 2018, at 6:22 PM, Sean Corfield notifications@github.com wrote:

This doesn't work because the deps.edn file is not at the top of the GitHub repo.

:rebel {:extra-deps {com.bhauman/rebel-readline {:git/url "https://github.com/bhauman/rebel-readline" :sha "c943ebe6d8ebc577414927c5df86f523f4c1c6c8"}} :main-opts ["-m" "rebel-readline.main"]} (because the project folks need to run is not at the root of the repo)

I wonder if there's a way to make this work -- @puredanger is this setup possible with deps.edn at the moment or would it need an enhancement?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[seancorfield]

FWIW, I added this to a fork of the repo, at the top level:

{:deps {com.bhauman/rebel-readline {:local/root "./rebel-readline"}}}

(I would assume similar cords for the other two projects)

That "works" for the local use of the repo however I still can't pull the repo from GitHub. I get this error:

Error building classpath. Manifest type not detected when finding deps for com.bhauman/rebel-readline in coordinate #:local{:root "./rebel-readline"}

I'm wondering if this is a bug tools.deps with local/root not working properly within git deps?

[seancorfield]

Confirmed, yes, a bug in tools.deps is preventing this from working properly: local deps don't work properly inside a git dependency.

Thanks for trying. https://github.com/seancorfield/rebel-readline/blob/master/deps.edn was my attempt at getting this to work (but blocked by the bug in tools.deps).