Closed bilalbutt044 closed 4 years ago
good work on Hover, however the image needs to be inverted, they images become too dark. @bilalbutt044
So should i create another PR? On Oct 9, 2019 5:11 AM, "Bhaumik Mistry" notifications@github.com wrote:
good work on Hover, however the image needs to be inverted, they images become too dark. @bilalbutt044 https://github.com/bilalbutt044
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bhaumikmistry/open-connect-art/pull/32?email_source=notifications&email_token=AHFN5OBQPXOQDSB5WWTXCIDQNUOUVA5CNFSM4I6YNKP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAWANXA#issuecomment-539756252, or mute the thread https://github.com/notifications/unsubscribe-auth/AHFN5OE5AOLMNEUOCQKZOKDQNUOUVANCNFSM4I6YNKPQ .
@bilalbutt044 please continue working on this pr only. https://github.com/bhaumikmistry/open-connect-art/pull/32#issuecomment-539757128
@bhaumikmistry I fixed this https://github.com/bhaumikmistry/open-connect-art/pull/32#issuecomment-539756252
solved issue #23
You need to take care of a few things while creating a pull requests.
Hover for the tile is working. I want to merge that pull request first. The contributors name is not working.
Okay, next time I will keep in mind before pull request. So what i have to do now to accept my pull request?
@bilalbutt044 contributors name does not show up when we hover, it is not functional, i can not merge.
this is solution of issue #24