change background color of tiles on hover for dark and light mood

bhaumikmistry / open-connect-art

Open connect art is an art display created by the open source community

https://bhaumikmistry.github.io/open-connect-art/

MIT License

8 stars 44 forks source link

change background color of tiles on hover for dark and light mood #32

Closed bilalbutt044 closed 4 years ago

bilalbutt044 commented 4 years ago

this is solution of issue #24

bhaumikmistry commented 4 years ago

good work on Hover, however the image needs to be inverted, they images become too dark. @bilalbutt044

bilalbutt044 commented 4 years ago

So should i create another PR? On Oct 9, 2019 5:11 AM, "Bhaumik Mistry" notifications@github.com wrote:

good work on Hover, however the image needs to be inverted, they images become too dark. @bilalbutt044 https://github.com/bilalbutt044

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bhaumikmistry/open-connect-art/pull/32?email_source=notifications&email_token=AHFN5OBQPXOQDSB5WWTXCIDQNUOUVA5CNFSM4I6YNKP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAWANXA#issuecomment-539756252, or mute the thread https://github.com/notifications/unsubscribe-auth/AHFN5OE5AOLMNEUOCQKZOKDQNUOUVANCNFSM4I6YNKPQ .

bhaumikmistry commented 4 years ago

@bilalbutt044 please continue working on this pr only. https://github.com/bhaumikmistry/open-connect-art/pull/32#issuecomment-539757128

bilalbutt044 commented 4 years ago

@bhaumikmistry I fixed this https://github.com/bhaumikmistry/open-connect-art/pull/32#issuecomment-539756252

bilalbutt044 commented 4 years ago

solved issue #23

bhaumikmistry commented 4 years ago

You need to take care of a few things while creating a pull requests.

Please split the issues into different Pull request. when I said make the change in the same PR is for improvement of the same issues.
Please restrict yourself from changing structure of the code as well. keep all the script to Js module. - Also keep the spaces same, please check the changes before creating the commits.
Your changes are all over all HTML file, it is very difficult to approve the pull request with a lot of different change for different issues.
Only touch the part of code which you want to change for a particular issues. for example do not reformat the code in the same pull request.

bhaumikmistry commented 4 years ago

Hover for the tile is working. I want to merge that pull request first. The contributors name is not working.

bilalbutt044 commented 4 years ago

Okay, next time I will keep in mind before pull request. So what i have to do now to accept my pull request?

bhaumikmistry commented 4 years ago

@bilalbutt044 contributors name does not show up when we hover, it is not functional, i can not merge.