search

bhaumikmistry / open-connect-art

Open connect art is an art display created by the open source community
https://bhaumikmistry.github.io/open-connect-art/
MIT License
8 stars 44 forks source link

Implemented the flicker button - issue #50 #55

Closed janelbrandon closed 5 years ago

janelbrandon commented 5 years ago

Changes the background of image cells to random colors from a random color palette

Added flicker.js with the logic. It defines some color palettes from https://www.color-hex.com/color-palettes/. It selects one palette randomly, then for each img cell, it selects a random background color from the palette.

It also changes the background color of the button to yellow. I also changed the foreground color of the button to a darker number so there is sufficient contrast.

I also added an id to the flicker button to make it easier to add the event handler.

Please let me know if you would like any changes.

janelbrandon commented 5 years ago

Sorry! I'll fix the conflicts

janelbrandon commented 5 years ago

There are some issues with the dark-mode enhancement ... some null pointers. I'll raise an issue and fix those first, then I'll update this PR.

bhaumikmistry commented 5 years ago
janelbrandon commented 5 years ago

I see you fixed it!

I've updated my PR to include your changes, and to take into account how flicker/dark-mode should behave when both are enabled. Let me know if you want me to make any changes! :)

janelbrandon commented 5 years ago

our spacing is different - I'm using VSCode extensions that space differently than what you have - so it makes the diff challenging. Sorry about that!