search

bhavesh-jadav / Advance-Card

Advance Card Visual for Power BI
http://bhaveshjadav.in/powerbi/advancecard/
GNU General Public License v3.0
25 stars 12 forks source link

Text Pushed Out of Card When Using Category Label in Internet Explorer #14

Closed cahilfoley closed 5 years ago

cahilfoley commented 5 years ago

Describe the bug When viewing the cards through the Power BI web application in Internet Explorer the text appears to be pushed out of the top of the box.

To Reproduce Steps to reproduce the behavior:

  1. Add an Advanced Card visualisation to a report
  2. Add a category label to the card
  3. Publish the report to the Power BI service
  4. View the report in Internet Explorer

Expected behavior The text should appear in the middle of the card as it does in most browsers (see screenshots below).

Screenshots Behaviour in Chrome (expected) chrome

Behaviour in IE internet-explorer

Desktop (please complete the following information):

Additional context IE's dev tools don't like me inspecting Power BI applications but from what I could load the problem looked like the issue was around this line. From what I could see of the error message was TypeError: Object doesn't support property or method 'getBBox'.

Removing the category label allows the card to behave normally.

bhavesh-jadav commented 5 years ago

@cahilfoley Thank you for detailed information.

Apparently getBBox method was not working in IE so I replaced it with getBoundingClientRect and that is working in IE. I have updated the visual and will be available in Power BI soon.

cahilfoley commented 5 years ago

That was fast! Thanks for fixing that up.

I've just checked and can confirm that it's all working as expecting in IE now 👍

Planda commented 5 years ago

Hi @bhavesh-jadav,

the problem still persist for me. I am using the visual on Power BI Report Server (August 2018), but even after update the category label is messing with the visual.

I am using IE 11.1209.15063.0. Do I need to update something on server side?

Thank you

bhavesh-jadav commented 5 years ago

This fix is available in version 1.1.2. Current available version on Power BI is v1.1.1. I have added version 1.1.2 on AppSource but it will take some time to available on Power BI.