search

bhavesh-jadav / Advance-Card

Advance Card Visual for Power BI
http://bhaveshjadav.in/powerbi/advancecard/
GNU General Public License v3.0
25 stars 12 forks source link

Added dropdown box to select locale #54

Open AlexanderK79 opened 3 years ago

AlexanderK79 commented 3 years ago

Dear Bhavesh,

thank you very much for your awesome tool! We are using it to generate nicely formatted cards... there's only one thing that's a bit annoying.... we can't get the regional options to work correctly for us in The Netherlands :-(

Numbers are formatted the en-us way (with a . (dot) instead of a , (comma) as a decimal separator. I saw you suggested in https://github.com/bhavesh-jadav/Advance-Card/issues/38 to change to a localized version of PowerBI, but that doesn't seem to work either.

Another (less elegant, I admit) way to force the Dutch number formatting is by specifying a dropdown box.

Would you be so kind as to honour this PR and publish the new version to AppSource, so we can use it in reports on app.powerbi.com and in report server.

Thank you very much in advance!

AlexanderK79 commented 3 years ago

Dear @bhavesh-jadav friendly reminder to accept the pull request :-)

bhavesh-jadav commented 3 years ago

Hi @AlexanderK79

I thank you for showing interest in Advance Card project and for making your own contribution to the project. If you build the pbiviz custom visual file from current available code on the master branch of the repo, it will pickup the correct localization settings based on user system or browser. I can pull your request and do the merge after reviewing it but I can not guarantee that I am going to publish the updated version on the AppSource. The custom visual submission process on the AppSource has changed quite significantly since when I first submitted the visual on the AppSource and in past, I tried to publish the current latest version available on the repo with localization fix and other new features on the AppSource for 3 times but each time it was rejected due to some minute reasons and each submission takes weeks for them to check. Also on the topic of adding new feature to the visual, We have to make sure that it is sustainable in future meaning once we add any new feature to the visual, it will be difficult to remove in future if we need to because if people are using that feature, it will break their reports and they have to redo most of the work around the visual When I get time in near future, I will go thourgh the AppSource submission process but till then, I suggest you build your own version of custom visual from the available code and use it in your reports. All the code is open source hence you can check it if you have any security concerns.

AlexanderK79 commented 3 years ago

Thank you for your clear answer... Is there any way we can ask Microsoft to help pass the AppSource submission process? I know they are active on other/their own custom visuals and maybe they are willing to incorporate your visual into PowerBI or give some feedback. Your visual is way better than the standard one in my opinion and MS should replace theirs with yours!

bhavesh-jadav commented 3 years ago

I am afraid the submission process is standard for everyone and there are no shortcuts to it. That is why I have kept the Advance Card open source so that people can take inspiration and build around that even though it is not updated in AppSource

smashmirrorcardboardface commented 2 years ago

I'd definitely recommend merging this one when you have the chance. along with the dropdown, it updates a load of stuff. Cheers to you both, I've forked Alexander's for now