search

bheesham / the-real-slim-ritual

Collect colours; rule the world.
Other
4 stars 3 forks source link

Jank code #2

Open bheesham opened 8 years ago

bheesham commented 8 years ago

Getting rid of the jank code is going to hopefully fix a lot of issues.

liuprestin commented 8 years ago

I have yet to checkout the code in depth (but I'll have time for it) - if the jank code can be labeled that would be very helpful.

bheesham commented 8 years ago

Will do.

The Princess code is... sketchy at times. Specifically the collisions and the handling of powers (i.e. toggling colours, cloning). They're very dependent on whether or not the clone exists.

One big bug we had before was that when a toggle command was pressed, both the princess and the clone would toggle the colours -- because they both have the same input hooks.

Probably related to the bug @ChristopherBlackman reported in #1.

ChristopherBlackman commented 8 years ago

Just wondering for the Jank code, for the collisions we could have a global class that keeps track of collisions. that way we can have the collisions a bit more diverse and object orientated instead of stuffing everything into the princess.

What do you guys think?

bheesham commented 8 years ago

I was thinking of making a new prefabs and having them manage their own collisions, and modify the game state accordingly. That way we just drag and drop prefabs, and we don't have to worry about the Game module becoming A God Module :tm: :copyright: :registered: .