Add Cuda Event - Githubissues

bheisler / RustaCUDA

Rusty wrapper for the CUDA Driver API

Apache License 2.0

758 stars 60 forks source link

Add Cuda Event #37

Closed LutzCle closed 5 years ago

LutzCle commented 5 years ago

This PR addresses issue #6.

bheisler commented 5 years ago

Hey, thanks for the pull request. It might be a few days before I can get a chance to review it in detail. In the meantime, I did notice that there aren't any tests for Stream::wait_event aside from the doctest - I think it might be possible to test it using Stream::add_callback as the asynchronous task. It wouldn't be a great test, but it would be something.

bheisler commented 5 years ago

Mostly looks good to me. It needs a few tweaks to the documentation but I can make those changes myself.

Thanks for the pull request!

LutzCle commented 5 years ago

Great, thanks! I'll be in touch with you about #38. I want to address your review when I find some free time.