Closed eisterman closed 4 years ago
I've added a commit to fix some space artifact left by Visual Studio Code.
Hi, thanks for the pull request! Unfortunately, your changes to mem::uninitialized
will conflict with another PR that I just merged; would you mind reverting (or rebasing out) that change?
Is this ok?
Looks good to me. Thanks!
I've noticed that the CI have a problem with the command
cargo clippy --all -- -D warnings
(CLIPPY=yes). The problem as seen in https://travis-ci.org/bheisler/RustaCUDA/jobs/630513201#L349 was some warning arose from clippy:clippy::needless-doctest-main
mem::uninitialized
is now deprecated in favour ofmem::MaybeUninit
clippy::missing-safety-doc
So I've made this pull request to fix all this problem. The solutions used are:
fn main() {}
from all the documentationstd::mem::uninitialized()
withstd::mem::MaybeUninit::uninit().assume_init()
/// # Safety:
comment removing the colon (/// # Safety
)/// # Safety
for 4 unsafe function really missing itPS: I have not opened an issue given the nature of the problem, strictly linked to the way in which continuous integration has been programmed.