search

bheisler / RustaCUDA

Rusty wrapper for the CUDA Driver API
Apache License 2.0
758 stars 60 forks source link

Add support for getting the UUID of a device #56

Closed vmx closed 2 years ago

vmx commented 3 years ago

This PR consists of two independent commits, the first one is the upgrade to cuda-driver-sys 0.3, the second one is the actual implementation API for getting the UUID.

Let me know if you'd prefer to have two separate PR, having it in a single one was just quicker for me as I had this branch already available.

Closes #55.

vmx commented 3 years ago

I forgot to add a changelog entry, I'll do that tomorrow.

vmx commented 2 years ago

Is there anything missing/I could help with to get this one merged? Or do I just need to be patient, which is also fine :)

bheisler commented 2 years ago

Hey, thanks for the pull request and for your patience so far.

The code looks good to me. Unfortunately I lost my CUDA development setup in an SSD crash a couple months ago and haven't set up a replacement yet, so I can't run the tests to verify that this actually works. I don't want to publish code I haven't tested, so I'll have to ask you to remain patient for a bit longer. I'll try to get that done by the end of this week.

bheisler commented 2 years ago

Merged. Thanks!

vmx commented 2 years ago

Thanks a lot, for getting setup again so quickly.