search

bheisler / criterion.rs

Statistics-driven benchmarking library for Rust
Apache License 2.0
4.59k stars 305 forks source link

Render Bar Charts #453

Open PSeitz opened 3 years ago

PSeitz commented 3 years ago

By default the thoughpout generates line charts. In my use case bar charts would be more approriate, since there is no sequence of input size.

bheisler commented 3 years ago

Hey, thanks for the suggestion!

I think this would be a small improvement for a niche use case and so I don't think it makes sense to add more API surface to allow benchmarks to configure it. I'm going to close this for now, but I'd be happy to revisit in the future if it turns out to be a more common need than I think it is.

PSeitz commented 3 years ago

It was requested here: https://www.reddit.com/r/rust/comments/kaj50o/lz4_flex_041_matches_now_the_cpp_lz4_reference/gfbjac7/?context=3 Number of up-votes suggests there is a clear opinion about this.

In my use case this is the default, because I usually benchmark against different kinds of input.

bheisler commented 3 years ago

Yeah, okay. It might not be a priority but I'll reopen this and probably get around to it eventually.

novacrazy commented 3 years ago

Bar charts would definitely be of use for comparisons with different data sets not on a line.