Bump clap to version 4 - Githubissues

bheisler / criterion.rs

Statistics-driven benchmarking library for Rust

Apache License 2.0

4.52k stars 301 forks source link

Bump clap to version 4 #679

Closed sjackman closed 1 year ago

sjackman commented 1 year ago

Bump clap to version 4. Bump MSRV to 1.64 for clap.

Use value_parser for numeric value types
Change possible_values to value_parser
Change hidden(true) to hide(true)
Change value_of and value_of_t_or_exit to get_one
Change is_present to get_flag or contains_id
Remove takes_value(true), since num_args(1) is the default
Use num_args(0) where needed

See https://github.com/clap-rs/clap/releases/tag/v3.2.0

sjackman commented 1 year ago

Thank you for merging!

sjackman commented 1 year ago

I see that the last stable release was version 0.4.0 on 2022-09-10. No rush, but might there be a stable release on the horizon that includes this change?

sjackman commented 1 year ago

@lemmih Thank you for the releases, David!