bheisler / criterion.rs

Statistics-driven benchmarking library for Rust
Apache License 2.0
4.31k stars 292 forks source link

Depend on itertools >=0.10, <0.12 #695

Closed sjackman closed 11 months ago

sjackman commented 1 year ago

Depend on itertools >=0.10, <0.12

sjackman commented 1 year ago

error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256' to 'C:\Users\appveyor\.rustup\tmp\81ucn_6cqhsxtqhp_file': failed to make network request: error sending request for url (https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256): error trying to connect: The message received was unexpected or badly formatted. (os error -2146893018): error trying to connect: The message received was unexpected or badly formatted. (os error -2146893018): The message received was unexpected or badly formatted. (os error -2146893018) Command exited with code 1 https://ci.appveyor.com/project/bheisler/criterion-rs/builds/47373637/job/agikfswe8n4heksh#L16

sjackman commented 1 year ago

In the previous build https://ci.appveyor.com/project/bheisler/criterion-rs/builds/47373637 ✅ Environment: TARGET=x86_64-pc-windows-msvc, GNUPLOT=yes ❌ Environment: TARGET=x86_64-pc-windows-msvc, GNUPLOT=no

In the current build (with no change to code) https://ci.appveyor.com/project/bheisler/criterion-rs/builds/47373729 ❌ Environment: TARGET=x86_64-pc-windows-msvc, GNUPLOT=yes ❌ Environment: TARGET=x86_64-pc-windows-msvc, GNUPLOT=no

sjackman commented 1 year ago

@lemmih Is there anything I need to change in this PR to get the AppVeyor CI check passing?

lemmih commented 1 year ago

@lemmih Is there anything I need to change in this PR to get the AppVeyor CI check passing?

You could make a separate PR that gets rid of AppVeyor.

sjackman commented 1 year ago

You could make a separate PR that gets rid of AppVeyor.

Done!

sjackman commented 11 months ago

@lemmih Thank you for merging my PR #699 to remove AppVeyor! Looks like this PR is now passing CI and good to go.

sjackman commented 1 week ago

@lemmih Thank you for merging this PR, David. Could you please push a new stable release to crates.io including this change when you have time?