search

bheisler / criterion.rs

Statistics-driven benchmarking library for Rust
Apache License 2.0
4.52k stars 301 forks source link

Update CI #707

Closed waywardmonkeys closed 1 year ago

waywardmonkeys commented 1 year ago

There's a chance that with the old action, it wasn't actually testing with the MSRV. I can reproduce this failure for 1.64 for wasm32-wasi locally. It also happens with 1.65 but not 1.66 or alter.

lemmih commented 1 year ago

There's a chance that with the old action, it wasn't actually testing with the MSRV. I can reproduce this failure for 1.64 for wasm32-wasi locally. It also happens with 1.65 but not 1.66 or alter.

Let's bump MSRV to 1.66?

waywardmonkeys commented 1 year ago

I'll come back to this and dig more. It bothers me. This feature should be in Rust 1.63, so 1.64 shouldn't be an issue. It will be a couple of days though.

waywardmonkeys commented 1 year ago

Looks like it is this: https://github.com/rust-lang/rust/issues/103306 which was fixed in 1.66 ... (it is 2:40am here and I should be asleep).

waywardmonkeys commented 1 year ago

@lemmih It seems a shame to update the MSRV so soon and for a fringe / experimental platform. Maybe it is okay to just skip this test except for on stable toolchain for now?

I've added a commit that does that in case you approve.