search

bheisler / criterion.rs

Statistics-driven benchmarking library for Rust
Apache License 2.0
4.31k stars 292 forks source link

Project does not build due to MSRV #728

Closed V0ldek closed 9 months ago

V0ldek commented 9 months ago

The project has an MSRV of 1.64, but the newest clap versions (starting from 4.4.6) require 1.70. This also causes the CI pipeline to fail.

Crietrion should either bump the MSRV as well, or pin clap to 4.4.5 to unbreak the build.

See relevant clap change.

I wanted to make a PR pinning 4.4.5, but the Contribution guide explicitly says to not submit dep-related PRs.

waywardmonkeys commented 9 months ago

I've submitted #731 that fixes this ... let's see what happens.

waywardmonkeys commented 9 months ago

@lemmih This can be closed now that #731 has landed.