search

bheisler / criterion.rs

Statistics-driven benchmarking library for Rust
Apache License 2.0
4.52k stars 301 forks source link

ci: Fix MSRV build by precisely specifying some deps. #731

Closed waywardmonkeys closed 11 months ago

waywardmonkeys commented 11 months ago

This also stops the build from cancelling all jobs once one fails, so that we can see the results for each version of Rust tested. Otherwise, the stable job fails (due to clippy) and we don't get results for the MSRV build.

waywardmonkeys commented 11 months ago

729 fixes the stable build and can be rebased forward and land once this one does.

lemmih commented 11 months ago

How about joining the two PRs? I'd feel much better about merging a PR that passes all the checks.

waywardmonkeys commented 11 months ago

@lemmih Okay, I've added the single commit here that should fix the current clippy build. The other PR contains further changes that go beyond just fixing the build.