search

bheisler / iai

Experimental one-shot benchmarking/profiling harness for Rust
Apache License 2.0
586 stars 24 forks source link

FIX: add cache-sim argument (fix issue 34) #35

Open sigaloid opened 1 year ago

sigaloid commented 1 year ago

Fixes #34.

If you want to use this before it gets merged, replace your iai line in Cargo.toml to this:

iai = { git = "https://github.com/sigaloid/iai", rev = "d56a597" }
niklasf commented 1 year ago

Confirmed that this fixes the issue (and stats appear to be unchanged).

bluebear94 commented 1 year ago

I am still getting a ‘no entry found for key’ panic with d56a597.

sigaloid commented 1 year ago

What version of valgrind are you on? And is it pointing to my fork in your Cargo.toml?

Strange that it still wouldn't work, as that's the only cause :(

bluebear94 commented 1 year ago

What version of valgrind are you on? And is it pointing to my fork in your Cargo.toml?

3.21.0, and yes, I removed Cargo.lock to make sure it was picking it up, and it still panics.

msrd0 commented 1 year ago

I can confirm the problem noticed by @bluebear94, I still get the error. Also, I found the following in the cargo output, verifying that this PR is used:


   Compiling iai v0.1.1 (https://github.com/sigaloid/iai?rev=d56a597#d56a5971)
KonradHoeffner commented 1 year ago

I needed a cargo update but afterwards it worked with iai = { git = "https://github.com/sigaloid/iai", rev = "d56a597" }.

KonradHoeffner commented 11 months ago

@sigaloid: I am relying on your bugfix in the HDT library on crates.io but depending on a GitHub repository is making me nervous. As the main developer of this project, @bheisler has been inactive for the last 2 and a half years and I could not find any contact information, it seems to me as if this won't get merged in the near future. Could you consider publishing your fork on crates.io, so other crates can reliably depend on a fixed version of iai?