search

bherrmann7 / Car-Cast

Car Cast is a simple Android podcast downloader and player. Optimized for use in a daily commute, it features big buttons, large text, remembers last played location. FOR MORE INFO ---> http://jadn.com/cc/
http://jadn.com/cc/
57 stars 30 forks source link

Only focus subscription URL for "Add". #100

Closed smblott-github closed 10 years ago

smblott-github commented 10 years ago

Hi again Bob,

Here's a small thing that's been bugging me. Perhaps it bugs you and/or others too.

Whenever you edit a subscription, the URL text box gets the focus. So the keyboard jumps onto the screen. Usually, that's not what I want.

You can get to this activity in one of three ways:

I promise. After this, I have just one change I'm interested in proposing. Well, for the time being. So I'll be off your back soon.

Thanks for the great work!

Steve

bherrmann7 commented 10 years ago

FYI.. The lastest rollout of carcast (last night) has a lot of people getting crashes. I'm not sure why. The stack traces are all pointing at CarCast.java line 141.

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.jadn.cc/com.jadn.cc.ui.CarCast}: java.lang.ClassCastException: android.widget.TextView cannot be cast to android.widget.ImageButton at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2211) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2261) at android.app.ActivityThread.access$600(ActivityThread.java:141) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1256) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:137) at android.app.ActivityThread.main(ActivityThread.java:5103) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:525) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553) at dalvik.system.NativeStart.main(Native Method) Caused by: java.lang.ClassCastException: android.widget.TextView cannot be cast to android.widget.ImageButton at com.jadn.cc.ui.CarCast.onCreate(CarCast.java:141) at android.app.Activity.performCreate(Activity.java:5133) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2175) ... 11 more

I'm assuming for now that this is just a sloppy build on my part (ie. I didnt do "ant clean" and then "ant release" - but I'm not sure thats the case...)

Any thoughts on what might cause this?

Thanks -bob

On 11/04/2013 06:41 AM, Stephen Blott wrote:

Hi again Bob,

Here's a small thing that's been bugging me. Perhaps it bugs you and/or others too.

Whenever you edit a subscription, the URL text box gets the focus. So the keyboard jumps onto the screen. Usually, that's no what I want.

You can get to this activity in one of three ways:

*

From the subscription list (|Edit|); in which case we probably
don't want to edit the URL, rather change one of the other
settings. So don't focus the URL.

*

From the |Add| entry on the subscription list menu; in which case
it /does/ make sense to focus the URL; that's probably where the
user will type/paste next.

*

From externally; in which case we already have a URL, so we're
unlikely to want to change it; so don't focus it.

I promise. After this, I have just one change I'm interested in proposing. Well, for the time being. So I'll be off your back soon.

Thanks for the great work!

Steve

    You can merge this Pull Request by running

git pull https://github.com/smblott-github/Car-Cast subscription-no-focus

Or view, comment on, or merge it at:

https://github.com/bherrmann7/Car-Cast/pull/100

    Commit Summary
bherrmann7 commented 10 years ago

FYI: I updated from the market, and now it crashes on my phone. I think It was a bad apk. -bob

On 11/04/2013 06:41 AM, Stephen Blott wrote:

Hi again Bob,

Here's a small thing that's been bugging me. Perhaps it bugs you and/or others too.

Whenever you edit a subscription, the URL text box gets the focus. So the keyboard jumps onto the screen. Usually, that's no what I want.

You can get to this activity in one of three ways:

*

From the subscription list (|Edit|); in which case we probably
don't want to edit the URL, rather change one of the other
settings. So don't focus the URL.

*

From the |Add| entry on the subscription list menu; in which case
it /does/ make sense to focus the URL; that's probably where the
user will type/paste next.

*

From externally; in which case we already have a URL, so we're
unlikely to want to change it; so don't focus it.

I promise. After this, I have just one change I'm interested in proposing. Well, for the time being. So I'll be off your back soon.

Thanks for the great work!

Steve

    You can merge this Pull Request by running

git pull https://github.com/smblott-github/Car-Cast subscription-no-focus

Or view, comment on, or merge it at:

https://github.com/bherrmann7/Car-Cast/pull/100

    Commit Summary
smblott-github commented 10 years ago

OK. I hope a new, clean build fixes it. It looks most likely from the stack trace.

bherrmann7 commented 10 years ago

Seems it was all me. I had not done a "ant clean" prior to an "ant release"

On Tue, Nov 5, 2013 at 1:02 AM, Stephen Blott notifications@github.comwrote:

OK. I hope a new, clean build fixes it. It looks most likely from the stack trace.

— Reply to this email directly or view it on GitHubhttps://github.com/bherrmann7/Car-Cast/pull/100#issuecomment-27749618 .