search

bherrmann7 / Car-Cast

Car Cast is a simple Android podcast downloader and player. Optimized for use in a daily commute, it features big buttons, large text, remembers last played location. FOR MORE INFO ---> http://jadn.com/cc/
http://jadn.com/cc/
57 stars 30 forks source link

Download progess sometimes shows a partial download even though the whole podcast comes down. #3

Closed pforhan closed 13 years ago

pforhan commented 14 years ago

I've had times when the graphical progress bar seems to indicate only 30% or so of the podcast downloads, but when I check it, it is there in its entirety.

bherrmann7 commented 14 years ago

I suspect issues 2 and 3 are really the same issue.

bherrmann7 commented 14 years ago

oh, that does sound different then. Sounds to me like an error computing the total number of bytes vs the size of the scrollbar. It's slightly complicated because the RSS feeds include a "size" of the mp3 file - but they dont appear to always be correct (that statement might need investigating.)

Podcast A might say its 3k in the rss, but only really be 2k when downloaded. Or the reverse it says 3k in the rss, but it is 6k when downloaded.

So I wonder, is there a problem where a podcast is reporting length in some other units (ie not bytes but seconds or something) ....

Perhaps after a successful download it should adjust the expected to match the actual and then recompute and update the progress-bar. This way all podcasts download correctly, then the progress bar will correctly show 100%.

pforhan commented 14 years ago

Before my latest changes, I had brought all your changes in, then re-applied mine. I thought I saw the adjustment code, but I still frequently see the progress bar not ended.

Perhaps, if we just hit the end of a successful download run, just set the bar's values to show complete regardless of the actual bytes (ie, progress = 1, total = 1)

bherrmann7 commented 14 years ago

Just forcing the bar complete would reduce user concern... but if we scanned and found 3 podcasts, but were only able to download 2 - do we still tell them that it was complete? I was thinking adding a detail button would be our chance to explain things.

pforhan commented 14 years ago

I would assume that if we couldn't download one or more, we would have some exceptions and wouldn't follow the "successful download" code path, so we wouldn't adjust the bar. Download details is a great idea, though.

bherrmann7 commented 14 years ago

The original first cut versions of carcast just had a Text area which filled with messages showing ever step it was doing... a bit overwhelming most of the time, but you could find out what exactly went wrong and what exactly was downloaded.

bherrmann7 commented 14 years ago

(same comment added to issue 2) last night I pushed out an update to carcast... CarCast Sept-10 1.0.69

I've added a setting, "Show complete downloads", which gives the detailed download view when you start downloading podcasts. It also has an email menu item which allows the download details to be easily emailed to carcast-devs@googlegroups.com for review.

I'm now working on changes to the history file so that you can erase the history for a given subscription.

bherrmann7 commented 13 years ago

I'm closing this as I think it's a duplicate of two.