bhj / KaraokeEternal

Open karaoke party system
https://www.karaoke-eternal.com
ISC License
460 stars 70 forks source link

[Feature Request] Provide Users With a "Sing" or "Start" and "Skip" Button #46

Closed ctlw83 closed 2 years ago

ctlw83 commented 2 years ago

I saw some of the recent comments about push notifications to let someone know either that their time to sing has arrived or during the song prior to theirs. However, even if someone is already in the room it might take time to shuffle around, etc.

In most KJ setups the KJ is in charge of starting/pausing the music for the next person, but what if they had the ability to start the song themselves or, if they want to skip their current turn but retain their same place in the rotation, to do that.

Feature Request Itself: Create a "Sing/Play" and "Skip" button on singers' views.

You could also create a "leave" button that a singer can use to leave the rotation completely and remove their songs from the current playlist, although, that is probably already in the system.

bhj commented 2 years ago

It's an interesting idea, and the detail is appreciated!

if they want to skip their current turn but retain their same place in the rotation

This is indeed how it works (the queue is not first-come first-serve).

As you rightly point out, there are many possible edge cases in a party setting. Rather than adding a lot of complexity to cover specific cases, the approach we're taking is to provide the basic tools to handle most common scenarios:

Essentially, if you are skipped for any reason you are two taps away from getting back to where you were. Right now I think this is a good balance between complexity and flexibility.

ctlw83 commented 2 years ago

Thanks for taking a look!