search

bhj / KaraokeEternal

Open karaoke party system
https://www.karaoke-eternal.com
ISC License
460 stars 70 forks source link

Text background doesn't match text #55

Closed al3ph closed 1 year ago

al3ph commented 1 year ago

I'm seeing the lyric text background repeatedly not match the text. I'm guessing this is driven by CDGGraphics module and it's reporting the wrong values ?

So I'm not sure this is fixable, but I see you've contributed to the repo, so thought this might be of interest.

cheers.

al3ph commented 1 year ago

Screenshot from 2023-02-26 10-50-11

al3ph commented 1 year ago

If I pause playback, and then change the background value, the bounding box corrects itself. So it looks like something isn't syncing with the contentBounds correctly.

bhj commented 1 year ago

Hi, first, which browser is this and does it occur in others? When you say "change the background value" can you be more specific? The blur is generated by a div with the backdrop-filter property, so I'd start by inspecting it to determine if it's the right size.

What I think you're describing (making some change to re-paint the element fixes its filter rendering) sure sounds like a browser issue, but happy to implement a workaround PR if needed!

al3ph commented 1 year ago

By background value, I mean the slider that controls the opacity of the the background.

I'm using

Google Chrome Version 110.0.5481.177 (Official Build) (64-bit) (Linux Ubuntu)

I'll have a go with Firefox when I get the chance, and get back to you, cheers.

bhj commented 1 year ago

Assuming this is sorted; can re-open if not!