search

bhklab / CoreGx

Shared code for both PharmacoGx and RadioGx
https://bhklab.github.io/CoreGx/
GNU General Public License v3.0
2 stars 3 forks source link

Fixing a bug in sorting the y values in the same order as x #135

Closed p-smirnov closed 2 years ago

p-smirnov commented 2 years ago

Previous code tried to be clever, but failed to keep track of the fact that if we sort x, is.unsorted(x) will start to evaluate to false later.

IMO, the flow is better working with 1 variable at a time, so I added a flag to remember the sorted status of the data.

ChristopherEeles commented 2 years ago

I will fix my comments.