bhklab / CoreGx

Shared code for both PharmacoGx and RadioGx
https://bhklab.github.io/CoreGx/
GNU General Public License v3.0
2 stars 3 forks source link

Improve output of callingWaterfall.R#L54 #183

Open bhaibeka opened 3 months ago

bhaibeka commented 3 months ago

Add an output and/or a message to inform the user that the linear approximation has been used. I would also store all the parameters used to call to categorize cell lines based on their drug response data (ie, type, intermediate.fold , and cor.min.linear)

jjjermiah commented 3 months ago

context:

The cor.min.linear argument appears to be the minimum Pearson correlation coefficient between the linear distribution model and actual drug response values, such that the waterfall distribution can be called linear triggering the alternate method for determining two sensitivity groups. Is this correct?

Following this, in the output, will it be obvious which of the two methods was used to great two groups?

Additionally, it may also be useful to know if we should be using the defaults for the cor.min.linear and intermediate.fold arguments.

1) Add output message of which method has been used

Relevant code:

https://github.com/bhklab/CoreGx/blob/bf6d814abd3dc0fc98f9f419f430cc6473046cb2/R/callingWaterfall.R#L104C5-L122C6

2) Store parameters used in function

Do we want to return these to the user (named list) or output as a message (or both?)

jjjermiah commented 3 months ago

@bhaibeka 1) added info messages if logging options set to verbose 2) return the parameters and cutoff information as attributes

image