bhklab / PharmacoGx

R package to analyze large-scale pharmacogenomic datasets.
http://pharmacodb.pmgenomics.ca
GNU General Public License v3.0
64 stars 26 forks source link

increasing the default precision so that the pattern search tends to … #117

Closed p-smirnov closed 2 years ago

p-smirnov commented 2 years ago

…fall within 1e-3 of the optim results (optim convergence seems to be platform dependent).

The fact that optim convergence on some platforms and doesn't on others with the same data is unsettling, but now pattern search gives out results that match to within 1e-3. There could be an argument made for greater tolerance for errors, but on the log 10 scale 0.01 can actually be meaningful.