bhklab / readii

Radiomic Extraction and Analysis for DICOM Images (READII)
MIT License
3 stars 0 forks source link

deps: `dicom-parser` #41

Closed jjjermiah closed 3 weeks ago

jjjermiah commented 1 month ago

Wondering if the dicom-parser library is still required:

It seems to only be used once to load a Series and pull some metadata from it:

https://github.com/bhklab/readii/blob/3b57b49cedbced3d2a668a6257b62a4e6cb4026a/src/readii/image_processing.py#L117-L149

Wondering if this functionality is too difficult to extract from the loaders built into Readii already?

If too much work, we can ignore this lol

strixy16 commented 1 month ago

That function is specifically for images that have mismatched dimensions. I specifically need information from the DICOM header, which isn't something that I could easily get from the med-imagetools image loaders at the time. Could be something we solve when we update MIT and READII 2.0.

skim2257 commented 1 month ago

it seems the Series() class is used to index first and last instanceUIDs, which is already stored when crawling, but it's only saved in _imgtools.json