search

bhlangonijr / chesslib

chess library for legal move generation, FEN/PGN parsing and more
Apache License 2.0
225 stars 78 forks source link

Site tag in Game #17

Open vixen opened 5 years ago

vixen commented 5 years ago

One suggestion :

Reason lichess.org site puts specific game id in site tag in their pgn

Example

[Site "https://lichess.org/<gameid>"]

While u parse the pgn the only way to get site is via PGN's event map and it only has site for last game of that event and there is now way we can get specific game id

bhlangonijr commented 5 years ago

Hello @vixen,

According to PGN spec Site is the location of the event. It seems a bit odd they use this field for storing the game id. Ideally they would make use of a custom field. Are there any other tools or websites using this tag for the same purpose? I mean I can sacrifice the spec for enabling a "de facto" interpretation of this tag.

vixen commented 5 years ago

Thanks for your reply Your project is awesome May be these events/games are online so location/site is an online url only

In case of human events also sometimes different rounds happen at different locations. If I remember correctly once(may be more) for Linares first round happened at Moralia(Mexico) and second round at Linares (Spain). Anway this is an exception rather than a norm So feel free to take decision Thanks

bhlangonijr commented 5 years ago

I'll go ahead and take your suggestion. The change should be available in the next release.