Open bhnuka opened 10 months ago
The duplicate tag is not an error and should not be referred to as such in the table along with invalid command, index or the alphanumeric statement. It is an intended behaviour which informs the user of duplicate tags from their input in the command output as seen by the screenshot, so it should not be in the potential errors table or mentioned separately as it is a part of the command output message which is clearly shown in the screenshot. But we do understand that the DG was not clear in showing the use case for addTag, so the bug is actually in the DG for which case this would be a duplicate of the Issue#2552.
Team chose [response.Rejected
]
Reason for disagreement: There's no obvious reference to the fact that if the tag already exists, it will not be added, other than an incredibly brief mention in the caption of a screenshot. While not necessary to be categorised under potential errors (as this is not an error, just another outcome), as the lack of explicit documentation regarding the fact that duplicate tags will not be added to the contact hinders the user in their use of the product, I believe this is a documentation bug. Additionally, you stated that this issue is a duplicate but did not tag the duplicate. As such, I cannot verify if the duplicate is valid or not.
UG only states invalid command, invalid index and should be alphanumeric. no mention on duplicate tags (but dg has).